Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --network-dataplane flag #318

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented May 1, 2024

Description
This pr gates the node labels we add to be gated alongside network dataplane only adding the cilium labels when cilium is enabled.
How was this change tested?

  • make presubmit

Release Note

introducing the --network-dataplane flag

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 10487211145

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.702%

Totals Coverage Status
Change from base Build 10380396551: 0.001%
Covered Lines: 36308
Relevant Lines: 37162

💛 - Coveralls

@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review May 7, 2024 05:22
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator

@comtalyst comtalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(discussed offline)

Approving code changes in general.
But let's make sure we get things right on the relationship between NetworkPolicy and NetworkDataplane.

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian merged commit f6fd9cd into Azure:main Aug 22, 2024
11 checks passed
Bryce-Soghigian added a commit that referenced this pull request Sep 12, 2024
* feat: --network-dataplane flag

* commit from codespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants